Fix Utils CI #1867
Merged
Fix Utils CI #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasMoutawwakil
requested review from
echarlaix,
fxmarty and
mht-sharma
and removed request for
fxmarty,
mht-sharma and
echarlaix
IlyasMoutawwakil
force-pushed
the
fix-utils-ci
branch
from
b3db829
to
d50e1f9
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
approved these changes
May 24, 2024
.github/workflows/test_utils.yml
Outdated
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Free Disk Space (Ubuntu) | ||
| uses: jlumbroso/free-disk-space@main |
There was a problem hiding this comment.
also do you think we can reduce the model / dataset size used during testing https://github.com/huggingface/optimum/blob/main/tests/utils/test_dummpy_input_generators.py#L38 ? (using tiny random models for example)
.github/workflows/test_utils.yml
Outdated
Comment on lines
23
to
27
| - name: Free Disk Space (Ubuntu) | ||
| uses: jlumbroso/free-disk-space@main | ||
| if: matrix.os == 'ubuntu-20.04' | ||
| with: | ||
| tool-cache: true |
There was a problem hiding this comment.
tests/utils/test_task_processors.py
Outdated
| @@ -157,11 +160,15 @@ def _test_load_dataset( | |||
| path, | |||
| data_keys=data_keys, | |||
| only_keep_necessary_columns=only_keep_necessary_columns, | |||
| load_smallest_split=True, | |||
|
still fails after two datasets 🥲 |
|
reducing the number of samples works (it was the tensors written to disk memory and not the dataset splits) |
mht-sharma
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes tasks processor ci
Before submitting
Who can review?